timsaucer commented on PR #1073: URL: https://github.com/apache/datafusion-python/pull/1073#issuecomment-2766787598
I don't think these changes make a substantive difference to the example. One of the main goals of the examples to be as simple and clear as possible for new users to understand the basic API usage. Error trapping is a good and useful practice but this looks like it detracts from the core intent of the example. If we are going to add it in, then a single try/except block would be my recommended approach rather than these detailed messages for every step of the process. I haven't reviewed each of the stages in these calls to see if it's possible to throw exceptions at every stage, either. I'll add a note to the original issue report asking for clarity of what they think is the bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
