gabotechs commented on code in PR #14412:
URL: https://github.com/apache/datafusion/pull/14412#discussion_r2026415116
##########
datafusion/functions-aggregate/src/string_agg.rs:
##########
@@ -65,6 +83,7 @@ make_udaf_expr_and_func!(
#[derive(Debug)]
pub struct StringAgg {
signature: Signature,
+ array_agg: ArrayAgg,
}
Review Comment:
I don't think I've seen this pattern much in DataFusion codebase about
reusing another function as a building block. Any opinions about this approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
