xudong963 commented on code in PR #15539:
URL: https://github.com/apache/datafusion/pull/15539#discussion_r2030606238
##########
datafusion/datasource/src/file_groups.rs:
##########
@@ -263,7 +264,21 @@ impl FileGroupPartitioner {
.flatten()
.chunk_by(|(partition_idx, _)| *partition_idx)
.into_iter()
- .map(|(_, group)| FileGroup::new(group.map(|(_, vals)|
vals).collect_vec()))
+ .map(|(_, group)| {
+ FileGroup::new(
Review Comment:
Yes, we can. But need to do some refactors for the
`compute_file_group_statistics` method.
It's difficult to get `file_schema` here, and luckily, the
`compute_file_group_statistics` method doesn't necessarily need the argument.
https://github.com/apache/datafusion/pull/15539/commits/736a029bb3327a8822afce1c0de9123f1a6559b2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
