adriangb commented on code in PR #15566:
URL: https://github.com/apache/datafusion/pull/15566#discussion_r2033630457
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -467,6 +468,439 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
) -> Result<Option<Arc<dyn ExecutionPlan>>> {
Ok(None)
}
+
+ /// Attempts to recursively push given filters into this `ExecutionPlan` or
+ /// its children and push any filters from this node into its children.
+ ///
+ /// This is used to implement filter pushdown in the physical plan. Note
+ /// that DataFusion also implements filter pushdown in the logical plan,
+ /// which is a different code path. This method is here to support
+ /// additional optimizations that may be only be possible in the physical
+ /// plan such as dynamic filtering (see below).
+ ///
+ /// See [`try_pushdown_filters_to_input`] for a simple implementation
+ ///
+ /// # Arguments
+ /// * `plan`: `Arc`d instance of self
+ /// * `parent_filters`: A vector of [`PhysicalExpr`]s from the parent of
this node
+ /// to try and push down
Review Comment:
```suggestion
/// to try and push down
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
