adriangb commented on code in PR #15566:
URL: https://github.com/apache/datafusion/pull/15566#discussion_r2035397116
##########
datafusion/datasource/src/source.rs:
##########
@@ -254,3 +284,13 @@ impl DataSourceExec {
})
}
}
+
+/// Create a new `DataSourceExec` from a `DataSource`
Review Comment:
@alamb sneaked this bit in, wdyt Andrew?
##########
datafusion/physical-expr/src/utils/mod.rs:
##########
@@ -47,6 +47,31 @@ pub fn split_conjunction(
split_impl(Operator::And, predicate, vec![])
}
+/// Create a conjunction of the given predicates.
+/// If the input is empty, return a literal true.
+/// If the input contains a single predicate, return the predicate.
+/// Otherwise, return a conjunction of the predicates (e.g. `a AND b AND c`).
+pub fn conjunction(
+ predicates: impl IntoIterator<Item = Arc<dyn PhysicalExpr>>,
+) -> Arc<dyn PhysicalExpr> {
+ conjunction_opt(predicates).unwrap_or_else(||
crate::expressions::lit(true))
+}
+
+/// Create a conjunction of the given predicates.
Review Comment:
There's actually several places where it's useful to know if the result is
`lit(true)` because you handle that differently. E.g. `FilterExec` drops itself
out of the plan. And it's only a small bit more code to have here to avoid
having to match `lit(true)` in other places.
##########
datafusion/physical-plan/src/filter_pushdown.rs:
##########
@@ -0,0 +1,62 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+pub use datafusion_expr::FilterPushdown;
+use datafusion_physical_expr::PhysicalExprRef;
+
+/// The combined result of a filter pushdown operation.
+/// This includes:
+/// * The inner plan that was produced by the pushdown operation.
+/// * The support for each filter that was pushed down.
+pub enum FilterPushdownResult<T> {
Review Comment:
It can also be a FileSource, etc. I will try to tweak the comments to use
the terminology "node"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
