jayzhan211 commented on PR #15568: URL: https://github.com/apache/datafusion/pull/15568#issuecomment-2796973499
https://github.com/apache/datafusion/pull/15685 @adriangb, the `snapshot` is different but I think the overall idea should be the same, while we avoid remapping each time we call `evaluate()` and I think the `with_new_children` and `update` are the same now. I couldn't remove `Arc<RwLock>` yet because we can't mutate in `with_new_children`, it might be possible to avoid it with some tricks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
