mbutrovich commented on code in PR #15537:
URL: https://github.com/apache/datafusion/pull/15537#discussion_r2042769032
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -438,6 +438,22 @@ impl ParquetSource {
}
}
+/// Parses datafusion.common.config.ParquetOptions.coerce_int96 String to a
arrow_schema.datatype.TimeUnit
+fn parse_coerce_int96_string(str_setting: &str) ->
datafusion_common::Result<TimeUnit> {
+ let str_setting_lower: &str = &str_setting.to_lowercase();
+
+ match str_setting_lower {
+ "ns" => Ok(TimeUnit::Nanosecond),
+ "us" => Ok(TimeUnit::Microsecond),
+ "ms" => Ok(TimeUnit::Millisecond),
+ "s" => Ok(TimeUnit::Second),
Review Comment:
I don't know of any systems that do this, but I didn't take my absence of
knowledge as proof some system out there doesn't do it. This basically just
matches the behavior that we put into arrow-rs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
