aharpervc commented on code in PR #1809:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/1809#discussion_r2042385712


##########
src/parser/mod.rs:
##########
@@ -15017,6 +15026,48 @@ impl<'a> Parser<'a> {
         }
     }
 
+    fn parse_go(&mut self) -> Result<Statement, ParserError> {
+        // previous token should be a newline (skipping non-newline whitespace)

Review Comment:
   Does [my comment 
above](https://github.com/apache/datafusion-sqlparser-rs/pull/1809#discussion_r2042359100)
 & the code comment below, "using this peek function because we want to halt 
this statement parsing upon newline" help?
   
   ```mssql
   -- this should parse as `Go { Some(4) }`
   GO 4
   
   -- this should parse as something like `Go { None }`, `Expr(4)`
   GO
   4
   ```
   
   Eg, the whitespace is meaningful for parsing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to