andygrove commented on code in PR #1593:
URL: https://github.com/apache/datafusion-comet/pull/1593#discussion_r2044569591
##########
common/src/main/java/org/apache/comet/parquet/BatchReader.java:
##########
@@ -282,6 +282,7 @@ public void init() throws URISyntaxException, IOException {
// Initialize missing columns and use null vectors for them
missingColumns = new boolean[columns.size()];
List<String[]> paths = requestedSchema.getPaths();
+ ShimFileFormat.findRowIndexColumnIndexInSchema(sparkSchema);
Review Comment:
would you mind adding a comment explaining that the result is unused but
that the call has side effects?
perhaps adding `let _ = ` would help make this clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
