logan-keede commented on code in PR #15680:
URL: https://github.com/apache/datafusion/pull/15680#discussion_r2045577390
##########
datafusion/sql/tests/cases/diagnostic.rs:
##########
@@ -20,16 +20,18 @@ use insta::assert_snapshot;
use std::{collections::HashMap, sync::Arc};
use datafusion_common::{Diagnostic, Location, Result, Span};
-use datafusion_sql::planner::{ParserOptions, SqlToRel};
+use datafusion_sql::{
+ parser::{DFParser, DFParserBuilder},
+ planner::{ParserOptions, SqlToRel},
+};
use regex::Regex;
-use sqlparser::{dialect::GenericDialect, parser::Parser};
use crate::{MockContextProvider, MockSessionState};
fn do_query(sql: &'static str) -> Diagnostic {
- let dialect = GenericDialect {};
- let statement = Parser::new(&dialect)
- .try_with_sql(sql)
+ // let dialect = GenericDialect {};
+ let statement = DFParserBuilder::new(sql)
Review Comment:
This is somewhat out of the way, but I think using `DFParser` makes more
sense here, as that's what is ultimately expected to be used by user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
