comphead commented on code in PR #15680:
URL: https://github.com/apache/datafusion/pull/15680#discussion_r2047736900
##########
datafusion/sql/src/parser.rs:
##########
@@ -438,12 +440,26 @@ impl<'a> DFParser<'a> {
&self,
expected: &str,
found: TokenWithSpan,
- ) -> Result<T, ParserError> {
- parser_err!(format!("Expected {expected}, found: {found}"))
+ ) -> Result<T, DataFusionError> {
+ let sql_parser_span = found.span;
+ parser_err!(format!(
Review Comment:
this actually gives me an idea that `err!` should support diagnostics as
optional param, so we can remove extra `map_err`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
