Max-Meldrum commented on PR #15612: URL: https://github.com/apache/datafusion/pull/15612#issuecomment-2812023934
> > Seems like it is actually trying to compile the doctest code. If this isn't required then perhaps a `no_run` is in order? > > Yes, we run all the examples in the doc tests -- instructions for doing so locally are here > > https://github.com/apache/datafusion/blob/784df33f8930f91eada0d67aa5acc25a4c25cea2/datafusion/core/src/lib.rs#L836-L861 > > The idea is to ensure that the examples in the docs do not drift apart from reality Right, I see. The current example code is using stuff that is external to the Datafusion repo and is over at [datafusion-uwheel](https://github.com/uwheel/datafusion-uwheel). For instance the [try_rewrite](https://github.com/uwheel/datafusion-uwheel/blob/2c88c5ea7629515ad551f968108e87de4133fe5f/datafusion-uwheel/src/lib.rs#L246) function. What could be a good approach here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
