timsaucer commented on PR #15646: URL: https://github.com/apache/datafusion/pull/15646#issuecomment-2815465523
I've been working through switching over to returning field instead of data type. This had many touch points. The PR has grown very large, but a significant portion of that is updating unit tests to pass in the appropriate values. One big change occurs in `datafusion/expr/src/expr_schema.rs` where I moved over the logic that was in `data_type_and_nullable` *and* `metadata` into `to_field`. Then the other two functions call `to_field` and pick out the parts they want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
