xudong963 commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2051496431
##########
datafusion/expr/src/expr.rs:
##########
@@ -701,6 +701,24 @@ impl TryCast {
}
}
+/// OrderBy Expressions
+pub enum OrderByExprs {
+ OrderByExprVec(Vec<OrderByExpr>),
+ All {
+ exprs: Vec<Expr>,
+ options: OrderByOptions,
+ },
+}
Review Comment:
I'm not sure if we need the Enum.
Maybe it's enough to wrap `Vec<OrderByExpr>` as a struct and add an extra
flag to indicate the `ALL`
```rust
pub struct OrderByExprs {
exprs: Vec<OrderByExpr>,
all: bool
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
