alamb commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2069775315
##########
datafusion/expr/src/expr.rs:
##########
@@ -701,6 +701,24 @@ impl TryCast {
}
}
+/// OrderBy Expressions
+pub enum OrderByExprs {
+ OrderByExprVec(Vec<OrderByExpr>),
+ All {
+ exprs: Vec<Expr>,
+ options: OrderByOptions,
+ },
+}
Review Comment:
this enum seems to only be used in the sql planner, so I don't think it is
needed in `datafusion-expr` -- maybe we can just move this into the
datafusion-sql crate and make it `pub(crate)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
