andygrove commented on code in PR #1664:
URL: https://github.com/apache/datafusion-comet/pull/1664#discussion_r2052591956


##########
spark/src/test/scala/org/apache/comet/CometFuzzTestSuite.scala:
##########
@@ -206,10 +206,15 @@ class CometFuzzTestSuite extends CometTestBase with 
AdaptiveSparkPlanHelper {
   }
 
   private def testParquetTemporalTypes(
-      outputTimestampType: ParquetOutputTimestampType.Value): Unit = {
+      outputTimestampType: ParquetOutputTimestampType.Value,
+      generateArray: Boolean = true,

Review Comment:
   It would be good to start testing maps as well in the fuzz suite. Some of 
the existing tests cannot work with map types though (because maps don't 
implementing ordering). We may need to add new map-specific tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to