gabotechs opened a new pull request, #15794:
URL: https://github.com/apache/datafusion/pull/15794
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #13864.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
The `consumer.rs` file grew a bit too big (~3400 LOC). Good thing is that
it's easily splittable into separate files, each one responsible for converting
one Substrait node into one DataFusion Logical plan node. With this change,
people can just go to the file that they care about greatly reducing the amount
of information that they need to deal with.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
A refactor of Substrait `consumer.rs` file into multiple files following
these rules:
- Every `from_*` prefixed function responsible for converting one Substrait
node into one DataFusion Logical plan node is now factored out into its own
file named after the original Substrait node (e.g. `cast.rs`, `literal.rs`,
`aggregate_rel.rs`
- Every helper function that was only used once for a specific node
conversion is moved to the same file that holds the node conversion function
- Every helper function that is used by two or more node conversion
functions is moved to a `utils.rs` file
- The visibility rules of the functions to the outside is left intact,
making proper use of `pub(super)` for functions that now need to be shared
across different files.
- All the function names and function bodies are copy-pasted exactly as they
were
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
yes, by current pipelines.
## Are there any user-facing changes?
Nothing, just a pure refactor.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
