timsaucer commented on code in PR #15646:
URL: https://github.com/apache/datafusion/pull/15646#discussion_r2052893257
##########
datafusion/core/tests/user_defined/user_defined_scalar_functions.rs:
##########
@@ -803,17 +806,17 @@ impl ScalarUDFImpl for TakeUDF {
&self.signature
}
fn return_type(&self, _args: &[DataType]) -> Result<DataType> {
- not_impl_err!("Not called because the return_type_from_args is
implemented")
+ not_impl_err!("Not called because the return_field_from_args is
implemented")
}
/// This function returns the type of the first or second argument based on
/// the third argument:
///
/// 1. If the third argument is '0', return the type of the first argument
/// 2. If the third argument is '1', return the type of the second argument
- fn return_type_from_args(&self, args: ReturnTypeArgs) ->
Result<ReturnInfo> {
- if args.arg_types.len() != 3 {
- return plan_err!("Expected 3 arguments, got {}.",
args.arg_types.len());
+ fn return_field_from_args(&self, args: ReturnFieldArgs) -> Result<Field> {
Review Comment:
This and also `return_field` in `PhysicalExpr`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
