paleolimbot commented on code in PR #15646:
URL: https://github.com/apache/datafusion/pull/15646#discussion_r2054292174
##########
datafusion/core/tests/user_defined/user_defined_scalar_functions.rs:
##########
@@ -1367,3 +1372,342 @@ async fn register_alltypes_parquet(ctx:
&SessionContext) -> Result<()> {
async fn plan_and_collect(ctx: &SessionContext, sql: &str) ->
Result<Vec<RecordBatch>> {
ctx.sql(sql).await?.collect().await
}
+
+#[derive(Debug)]
+struct MetadataBasedUdf {
+ name: String,
+ signature: Signature,
+ metadata: HashMap<String, String>,
+}
+
+impl MetadataBasedUdf {
+ fn new(metadata: HashMap<String, String>) -> Self {
+ // The name we return must be unique. Otherwise we will not call
distinct
+ // instances of this UDF. This is a small hack for the unit tests to
get unique
+ // names, but you could do something more elegant with the metadata.
+ let name = format!("metadata_based_udf_{}", metadata.len());
+ Self {
+ name,
+ signature: Signature::exact(vec![DataType::UInt64],
Volatility::Immutable),
+ metadata,
+ }
+ }
+}
+
+impl ScalarUDFImpl for MetadataBasedUdf {
+ fn as_any(&self) -> &dyn Any {
+ self
+ }
+
+ fn name(&self) -> &str {
+ &self.name
+ }
+
+ fn signature(&self) -> &Signature {
+ &self.signature
+ }
+
+ fn return_type(&self, _args: &[DataType]) -> Result<DataType> {
+ unimplemented!(
+ "this should never be called since return_field_from_args is
implemented"
+ );
+ }
+
+ fn return_field_from_args(&self, _args: ReturnFieldArgs) -> Result<Field> {
+ Ok(Field::new(self.name(), DataType::UInt64, true)
+ .with_metadata(self.metadata.clone()))
+ }
Review Comment:
Thanks - I'll do testing as well on our suite when this merges and see if we
can remove our internal workaround 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
