comphead commented on code in PR #1674:
URL: https://github.com/apache/datafusion-comet/pull/1674#discussion_r2054980178
##########
spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala:
##########
@@ -113,9 +114,9 @@ case class CometShuffleExchangeExec(
new CometShuffledBatchRDD(shuffleDependency, readMetrics, partitionSpecs)
override def runtimeStatistics: Statistics = {
- val dataSize = metrics("dataSize").value
+ val dataSize = metrics("dataSize").value *
CometConf.COMET_EXCHANGE_SIZE_MULTIPLIER.get(conf)
Review Comment:
`Math.max(CometConf.COMET_EXCHANGE_SIZE_MULTIPLIER.get(conf), 1)` ? to avoid
negative and 0 values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
