andygrove commented on code in PR #1674:
URL: https://github.com/apache/datafusion-comet/pull/1674#discussion_r2055055647
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -414,6 +414,16 @@ object CometConf extends ShimCometConf {
.doubleConf
.createWithDefault(10.0)
+ val COMET_EXCHANGE_SIZE_MULTIPLIER: ConfigEntry[Double] = conf(
+ "spark.comet.shuffle.sizeInBytesMultiplier")
+ .doc(
+ "Comet produces smaller shuffle files due to columnar compression and
this can result in " +
Review Comment:
We are using the uncompressed size of the Arrow batches, using this field in
`shuffle_writer`:
```rust
/// The original size of spilled data. Different to `spilled_bytes`
because of compression.
data_size: Count,
```
This is the code that updates it:
```rust
// Update data size metric
self.metrics.data_size.add(input.get_array_memory_size());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
