kazuyukitanimura commented on code in PR #1647: URL: https://github.com/apache/datafusion-comet/pull/1647#discussion_r2055002989
########## docs/source/contributor-guide/benchmarking_macos.md: ########## @@ -0,0 +1,145 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +# Comet Benchmarking on macOS + +This guide is for setting up TPC-H benchmarks locally on macOS using the 100 GB dataset. + +Note that running this benchmark on macOS is not ideal because we cannot force Spark or Comet to use performance +cores rather than efficiency cores, and background processes are sharing these cores. Also, power and thermal +management may throttle CPU cores. + +## Prerequisites + +Java and Rust must be installed locally. + +## Data Generation + +```shell +cargo install tpchgen-rs +tpchgen-cli -s 100 --format=parquet +``` + +## Clone the DataFusion Benchmarks Repository + +```shell +git clone https://github.com/apache/datafusion-benchmarks.git +``` + +## Install Spark + +Install Spark + +```shell +wget https://archive.apache.org/dist/spark/spark-3.5.4/spark-3.5.4-bin-hadoop3.tgz Review Comment: should we use 3.5.5? ########## docs/source/contributor-guide/benchmarking_macos.md: ########## @@ -0,0 +1,145 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +# Comet Benchmarking on macOS + +This guide is for setting up TPC-H benchmarks locally on macOS using the 100 GB dataset. + +Note that running this benchmark on macOS is not ideal because we cannot force Spark or Comet to use performance +cores rather than efficiency cores, and background processes are sharing these cores. Also, power and thermal +management may throttle CPU cores. + +## Prerequisites + +Java and Rust must be installed locally. + +## Data Generation + +```shell +cargo install tpchgen-rs +tpchgen-cli -s 100 --format=parquet +``` + +## Clone the DataFusion Benchmarks Repository + +```shell +git clone https://github.com/apache/datafusion-benchmarks.git +``` + +## Install Spark + +Install Spark + +```shell +wget https://archive.apache.org/dist/spark/spark-3.5.4/spark-3.5.4-bin-hadoop3.tgz +tar xzf spark-3.5.4-bin-hadoop3.tgz +sudo mv spark-3.5.4-bin-hadoop3 /opt +export SPARK_HOME=/opt/spark-3.5.4-bin-hadoop3/ +mkdir /tmp/spark-events +``` + + +Start Spark in standalone mode: + +```shell +$SPARK_HOME/sbin/start-master.sh +``` + +Set `SPARK_MASTER` env var (host name will need to be edited): + +```shell +export SPARK_MASTER=spark://Rustys-MacBook-Pro.local:7077 Review Comment: localhost? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org