adriangb commented on PR #15801: URL: https://github.com/apache/datafusion/pull/15801#issuecomment-2827824299
I don't understand where this `fetch()` method would go or how it will help. I feel that what you are proposing is not necessarily any simpler. It requires understanding several more APIs and isn't even less LOC. In my opinion what I have here is straight up simpler, but I admit that's somewhat a matter of personal taste. This is blocking work to some extent in the sense that I've had to work around the limitations of the current implementation in the TopK filter pushdown and other open PRs. Ultimately this is a working implementation that covers all cases and solves the current limitations. I do not understand the need to delay progress so we can shoehorn the implementation into using specific helper APIs for recursion that put limitations on how we structure our user facing APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
