adriangb commented on code in PR #15801:
URL: https://github.com/apache/datafusion/pull/15801#discussion_r2070340727
##########
datafusion/core/tests/physical_optimizer/push_down_filter.rs:
##########
@@ -154,29 +153,25 @@ impl FileSource for TestSource {
fn try_pushdown_filters(
&self,
- mut fd: FilterDescription,
+ filters: &[Arc<dyn PhysicalExpr>],
config: &ConfigOptions,
- ) -> Result<FilterPushdownResult<Arc<dyn FileSource>>> {
+ ) -> Result<FilterPushdownPropagation<Arc<dyn FileSource>>> {
+ let mut all_filters =
filters.iter().map(Arc::clone).collect::<Vec<_>>();
Review Comment:
Wouldn't the same be true if it was just `Vec<Arc<dyn PhysicalExpr>>`?
I tried implementing a struct with some helper methods but the thing is that
for `ExecutionPlan` we have a slightly different flow than `DataSource` and
`FileSource` (which are their own traits and hence need their own method) so
re-using the struct becomes a bit wonky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
