blaginin commented on code in PR #15793:
URL: https://github.com/apache/datafusion/pull/15793#discussion_r2059229206
##########
datafusion/common/src/format.rs:
##########
@@ -27,7 +27,3 @@ pub const DEFAULT_CAST_OPTIONS: CastOptions<'static> =
CastOptions {
safe: false,
format_options: DEFAULT_FORMAT_OPTIONS,
};
-
-pub const DEFAULT_CLI_FORMAT_OPTIONS: FormatOptions<'static> =
FormatOptions::new()
- .with_duration_format(DurationFormat::Pretty)
- .with_null("NULL");
Review Comment:
IMO, it would be good to add `NULL` to `DEFAULT_FORMAT_OPTIONS` -- but
because it requires updating a lot of tests, will do it separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
