blaginin commented on code in PR #15793:
URL: https://github.com/apache/datafusion/pull/15793#discussion_r2062708916
##########
datafusion/common/src/config.rs:
##########
@@ -1995,11 +2052,11 @@ config_namespace! {
}
}
-pub trait FormatOptionsExt: Display {}
+pub trait OutputFormatExt: Display {}
#[derive(Debug, Clone, PartialEq)]
#[allow(clippy::large_enum_variant)]
-pub enum FormatOptions {
+pub enum OutputFormat {
Review Comment:
Hey, thanks for checking this out 🙏! I feel like "format" can be better than
"output format" because:
- Below we've discussed that it would be good to add support for these
params in UDF functions - so in a way that _will be_ related to the objects.
- Output format IMO implies that it is something related to the way the file
is written - but in reality, it has nothing to do with the CSV /Parquet saving
##########
datafusion/common/src/config.rs:
##########
@@ -1995,11 +2052,11 @@ config_namespace! {
}
}
-pub trait FormatOptionsExt: Display {}
+pub trait OutputFormatExt: Display {}
#[derive(Debug, Clone, PartialEq)]
#[allow(clippy::large_enum_variant)]
-pub enum FormatOptions {
+pub enum OutputFormat {
Review Comment:
Hey, thanks for checking this out! 🙏 I feel like "format" can be better than
"output format" because:
- Below we've discussed that it would be good to add support for these
params in UDF functions - so in a way that _will be_ related to the objects.
- Output format IMO implies that it is something related to the way the file
is written - but in reality, it has nothing to do with the CSV /Parquet saving
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
