iffyio commented on code in PR #1759:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1759#discussion_r2062500408
##########
src/parser/mod.rs:
##########
@@ -10574,11 +10598,96 @@ impl<'a> Parser<'a> {
for_clause,
settings,
format_clause,
+ pipe_operators,
}
.into())
}
}
+ fn parse_pipe_operators(&mut self) -> Result<Vec<PipeOperator>,
ParserError> {
+ let mut pipe_operators = Vec::new();
+
+ while self.consume_token(&Token::VerticalBarRightAngleBracket) {
+ let kw = self.expect_one_of_keywords(&[
+ Keyword::SELECT,
+ Keyword::EXTEND,
+ Keyword::SET,
+ Keyword::DROP,
+ Keyword::AS,
+ Keyword::WHERE,
+ Keyword::LIMIT,
+ Keyword::AGGREGATE,
+ Keyword::ORDER,
+ ])?;
+ match kw {
+ Keyword::SELECT => {
+ let exprs =
self.parse_comma_separated(Parser::parse_select_item)?;
+ pipe_operators.push(PipeOperator::Select { exprs })
+ }
+ Keyword::EXTEND => {
+ let exprs =
self.parse_comma_separated(Parser::parse_select_item)?;
+ pipe_operators.push(PipeOperator::Extend { exprs })
+ }
+ Keyword::SET => {
+ let assignments =
self.parse_comma_separated(Parser::parse_assignment)?;
+ pipe_operators.push(PipeOperator::Set { assignments })
+ }
+ Keyword::DROP => {
+ let columns = self.parse_identifiers()?;
+ pipe_operators.push(PipeOperator::Drop { columns })
+ }
+ Keyword::AS => {
+ let alias = self.parse_identifier()?;
+ pipe_operators.push(PipeOperator::As { alias })
+ }
+ Keyword::WHERE => {
+ let expr = self.parse_expr()?;
+ pipe_operators.push(PipeOperator::Where { expr })
+ }
+ Keyword::LIMIT => {
+ let expr = self.parse_expr()?;
+ let offset = if self.parse_keyword(Keyword::OFFSET) {
+ Some(self.parse_expr()?)
+ } else {
+ None
+ };
+ pipe_operators.push(PipeOperator::Limit { expr, offset })
+ }
+ Keyword::AGGREGATE => {
+ let full_table_exprs = if
self.peek_keyword(Keyword::GROUP) {
+ vec![]
+ } else {
+ self.parse_comma_separated(|parser| {
+ parser.parse_expr_with_alias_and_order_by()
+ })?
+ };
+
+ let group_by_expr = if
self.parse_keywords(&[Keyword::GROUP, Keyword::BY]) {
+ self.parse_comma_separated(|parser| {
+ parser.parse_expr_with_alias_and_order_by()
+ })?
+ } else {
+ vec![]
+ };
+
+ pipe_operators.push(PipeOperator::Aggregate {
+ full_table_exprs,
+ group_by_expr,
+ })
+ }
+ Keyword::ORDER => {
+ self.expect_one_of_keywords(&[Keyword::BY])?;
+ let exprs =
self.parse_comma_separated(Parser::parse_order_by_expr)?;
+ pipe_operators.push(PipeOperator::OrderBy { exprs })
+ }
+ unhandled => {
+ unreachable!("`expect_one_of_keywords` further up allowed
unhandled keyword: {unhandled:?}");
Review Comment:
can we instead return an error instead of panicking? to avoid crashing on
bugs/mistakes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
