LucaCappelletti94 opened a new pull request, #1826: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1826
This pull request resolves the bug described in issue #1825, which was caused by an incorrect implementation of the named argument parsing. It also adds a few tests to verify that the new implementation is correct. The previous implementation made the incorrect assumption that arguments name cannot have the same name as types, but the set of types that are parsed as types in `sqlparser` is a superset of the types that are present in each dialect. Therefore, it is correct syntax to use as argument name for instance `int2` for PostgreSQL, while this same argument name would be interpreted as a type elsewhere. I have changed the parsing to determine via a look-ahead whether the name is a type or not. Best, Luca -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
