alamb commented on PR #14687: URL: https://github.com/apache/datafusion/pull/14687#issuecomment-2840392253
> LGTM. I think I'd like to see a test with multiple columns but the logic looks solid to me. I believe the use of unsafe is indeed ok given the conditions outlined. Thanks again for the review. I added the requested test. I think the CI is going to fail because of https://github.com/apache/datafusion/pull/15149#issuecomment-2840387613 Once that is fixed I'll refresh the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
