qstommyshu commented on code in PR #15893:
URL: https://github.com/apache/datafusion/pull/15893#discussion_r2068682558
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -3039,21 +2974,14 @@ Projection: a, b
.filter(and(col("b").gt(lit(10i64)), col("d").gt(lit(10i64))))?
.build()?;
- // filter on col b and d
Review Comment:
This part is a sanity check for the generated plan format, similar to other
parts commented with "// not part of the test, just good to know:", for example:
```Rust
// not part of the test, just good to know:
assert_eq!(
format!("{plan}"),
"\
Filter: b = Int64(1)\
\n Projection: test.a * Int32(2) + test.c AS b, test.c\
\n TableScan: test"
);
```
So I think this is not needed, it doesn't add much benefit to the code, just
a sanity check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
