blaginin commented on code in PR #15893:
URL: https://github.com/apache/datafusion/pull/15893#discussion_r2068983359


##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -3039,21 +2974,14 @@ Projection: a, b
             .filter(and(col("b").gt(lit(10i64)), col("d").gt(lit(10i64))))?
             .build()?;
 
-        // filter on col b and d

Review Comment:
   IMO it might be better for the insta migration PR not to change anything in 
the tests - just migrate everything. That way, we can treat these PRs as 
technical asset changes, review them quicker, and it'll be easier to understand 
the nature of the change when doing blame.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to