mbutrovich commented on code in PR #1697:
URL: https://github.com/apache/datafusion-comet/pull/1697#discussion_r2068751397
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1430,6 +1430,22 @@ object QueryPlanSerde extends Logging with CometExprShim
{
val optExpr = scalarFunctionExprToProto("ascii", childExpr)
optExprWithInfo(optExpr, expr, castExpr)
+ case StringDecode(binary, encoding) =>
+ encoding match {
+ case Literal(str, DataTypes.StringType) if str.toString == "utf-8" =>
Review Comment:
I'll check, but I expect Spark's front-end should have normalized this by
the time it hits us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
