andygrove commented on code in PR #1697:
URL: https://github.com/apache/datafusion-comet/pull/1697#discussion_r2068758199
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1430,6 +1430,22 @@ object QueryPlanSerde extends Logging with CometExprShim
{
val optExpr = scalarFunctionExprToProto("ascii", childExpr)
optExprWithInfo(optExpr, expr, castExpr)
+ case StringDecode(binary, encoding) =>
+ encoding match {
+ case Literal(str, DataTypes.StringType) if str.toString == "utf-8" =>
Review Comment:
You could update the test to pass the string in a different case to confirm
this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
