anuragmantri commented on code in PR #1654: URL: https://github.com/apache/datafusion-comet/pull/1654#discussion_r2069177697
########## dev/benchmarks/setup.sh: ########## @@ -0,0 +1,44 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Install Rust +sudo yum groupinstall -y "Development Tools" Review Comment: My RHEL9 EC2 instance did not have `wget`. May be we should add `yum install wget --y`? ########## dev/benchmarks/setup.sh: ########## @@ -0,0 +1,44 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Install Rust +sudo yum groupinstall -y "Development Tools" +curl https://sh.rustup.rs -sSf | sh -s -- -y +. "$HOME/.cargo/env" + +# Install Java +sudo yum install -y java-17-amazon-corretto-headless java-17-amazon-corretto-devel +export JAVA_HOME=/usr/lib/jvm/java-17-amazon-corretto + +# Build Comet +make release PROFILES="-Pspark-3.5" + +# Clone datafusion-benchmarks repo, which has the queries +git clone https://github.com/apache/datafusion-benchmarks.git + +# Install Spark +mkdir /home/ec2-user/tmp +wget https://dlcdn.apache.org/spark/spark-3.5.5/spark-3.5.5-bin-hadoop3.tgz +tar xzf spark-3.5.5-bin-hadoop3.tgz +cp spark-env.sh spark-3.5.5-bin-hadoop3/conf +export SPARK_HOME=/home/ec2-user/spark-3.5.5-bin-hadoop3/ Review Comment: this line has a trailing `/` ########## dev/benchmarks/setup.sh: ########## @@ -0,0 +1,44 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Install Rust +sudo yum groupinstall -y "Development Tools" +curl https://sh.rustup.rs -sSf | sh -s -- -y +. "$HOME/.cargo/env" + +# Install Java +sudo yum install -y java-17-amazon-corretto-headless java-17-amazon-corretto-devel +export JAVA_HOME=/usr/lib/jvm/java-17-amazon-corretto + +# Build Comet +make release PROFILES="-Pspark-3.5" + +# Clone datafusion-benchmarks repo, which has the queries +git clone https://github.com/apache/datafusion-benchmarks.git + +# Install Spark +mkdir /home/ec2-user/tmp Review Comment: Is the intention here to download and run Spark from `/home/ec2-user/tmp`? If so, we need to change the below lines to work from the /tmp directory. I would also do it only if it does not exist. How about this? ``` # Create tmp directory and install Spark if not already present mkdir -p /home/ec2-user/tmp cd /home/ec2-user/tmp if [ ! -d "spark-3.5.5-bin-hadoop3" ]; then wget https://dlcdn.apache.org/spark/spark-3.5.5/spark-3.5.5-bin-hadoop3.tgz tar xzf spark-3.5.5-bin-hadoop3.tgz fi ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
