NevroHelios commented on code in PR #15841:
URL: https://github.com/apache/datafusion/pull/15841#discussion_r2069897470
##########
benchmarks/src/util/options.rs:
##########
@@ -70,14 +71,12 @@ impl CommonOpt {
}
/// Modify the existing config appropriately
- pub fn update_config(&self, mut config: SessionConfig) -> SessionConfig {
- if let Some(batch_size) = self.batch_size {
- config = config.with_batch_size(batch_size)
- }
-
- if let Some(partitions) = self.partitions {
- config = config.with_target_partitions(partitions)
- }
+ pub fn update_config(&self, config: SessionConfig) -> SessionConfig {
+ let mut config = config
+ .with_target_partitions(
+ self.partitions.unwrap_or_else(get_available_parallelism),
Review Comment:
Thanks for pointing that out! I had originally added
`get_available_parallelism` to fix the clippy and compiler errors. After
updating the branch, now it works with the restored default configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
