NevroHelios commented on code in PR #15841:
URL: https://github.com/apache/datafusion/pull/15841#discussion_r2071709066
##########
benchmarks/src/util/options.rs:
##########
@@ -72,16 +72,11 @@ impl CommonOpt {
/// Modify the existing config appropriately
pub fn update_config(&self, mut config: SessionConfig) -> SessionConfig {
if let Some(batch_size) = self.batch_size {
- config = config.with_batch_size(batch_size)
+ config = config.with_batch_size(batch_size);
}
if let Some(partitions) = self.partitions {
- config = config.with_target_partitions(partitions)
- }
-
- if let Some(sort_spill_reservation_bytes) =
self.sort_spill_reservation_bytes {
- config =
-
config.with_sort_spill_reservation_bytes(sort_spill_reservation_bytes);
Review Comment:
During the copiler errors I updated this config but later I restored most
parts but I believe I mistakenly overlooked these lines during the process.
Thanks for points that out. I will push the updates shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
