timsaucer opened a new pull request, #15911: URL: https://github.com/apache/datafusion/pull/15911
## Which issue does this PR close? Closes https://github.com/apache/datafusion/issues/15902 ## Rationale for this change This change is a follow on to https://github.com/apache/datafusion/pull/15646. With this change we can now handle metadata for both window and aggregate functions. It enables the use of extension types via this metadata handling. ## What changes are included in this PR? Instead of passing `DataType` to aggregates and windows we now pass `Field` in their arguments. `return_type` has been replaced with `return_field` so we can get metadata out of these functions as well. ## Are these changes tested? All existing unit tests pass. New unit tests are added. ## Are there any user-facing changes? Yes, the migration guide contains information on the updates that the user will need to make for their user defined functions. ## TODO before moving to ready to review - [ ] Add unit test that is a window of an aggregate function - [ ] Verify migration guide covers both aggregate and window functions - [ ] Find remaining places where the function name doesn't match the arguments (ie: `fn return_type()` that returns a `Field`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
