iffyio commented on code in PR #1831:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1831#discussion_r2071047425
##########
src/parser/mod.rs:
##########
@@ -716,20 +734,36 @@ impl<'a> Parser<'a> {
let condition = match &start_token.token {
Token::Word(w) if w.keyword == Keyword::ELSE => None,
+ Token::Word(w) if w.keyword == Keyword::WHILE => {
+ let expr = self.parse_expr()?;
+ Some(expr)
+ }
_ => {
let expr = self.parse_expr()?;
then_token =
Some(AttachedToken(self.expect_keyword(Keyword::THEN)?));
Some(expr)
}
};
- let statements = self.parse_statement_list(terminal_keywords)?;
+ let conditional_statements = if self.peek_keyword(Keyword::BEGIN) {
+ let begin_token = self.expect_keyword(Keyword::BEGIN)?;
+ let statements = self.parse_statement_list(terminal_keywords)?;
+ let end_token = self.expect_keyword(Keyword::END)?;
Review Comment:
We seem to have this pattern upcoming in a few places, like #1810 maybe it
would be good to pull it out into a method and reuse it both here and the
preexisting usage
[here](https://github.com/apache/datafusion-sqlparser-rs/blob/main/src/parser/mod.rs#L5157-L5159)?
We can probably do so in the former PR instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
