Re: [PR] Perf: Optimize in memory sort [datafusion]

Fri, 02 May 2025 04:24:51 -0700 


alamb commented on PR #15380:
URL: https://github.com/apache/datafusion/pull/15380#issuecomment-2846984954

   ๐Ÿค–: Benchmark completed
   
   <details><summary>Details</summary>
   <p>
   
   
   ```
   Comparing HEAD and concat_batches_for_sort
   --------------------
   Benchmark sort_tpch.json
   --------------------
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Query        โ”ƒ      HEAD โ”ƒ concat_batches_for_sort โ”ƒ        Change โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ Q1           โ”‚  371.51ms โ”‚                315.35ms โ”‚ +1.18x faster โ”‚
   โ”‚ Q2           โ”‚  307.31ms โ”‚                241.42ms โ”‚ +1.27x faster โ”‚
   โ”‚ Q3           โ”‚ 1167.09ms โ”‚               1517.17ms โ”‚  1.30x slower โ”‚
   โ”‚ Q4           โ”‚  440.75ms โ”‚                373.42ms โ”‚ +1.18x faster โ”‚
   โ”‚ Q5           โ”‚  430.28ms โ”‚                424.70ms โ”‚     no change โ”‚
   โ”‚ Q6           โ”‚  454.68ms โ”‚                462.34ms โ”‚     no change โ”‚
   โ”‚ Q7           โ”‚  924.82ms โ”‚                941.63ms โ”‚     no change โ”‚
   โ”‚ Q8           โ”‚  780.68ms โ”‚                792.67ms โ”‚     no change โ”‚
   โ”‚ Q9           โ”‚  798.52ms โ”‚                811.82ms โ”‚     no change โ”‚
   โ”‚ Q10          โ”‚ 1231.02ms โ”‚               1218.71ms โ”‚     no change โ”‚
   โ”‚ Q11          โ”‚  742.85ms โ”‚                748.07ms โ”‚     no change โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ณโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”“
   โ”ƒ Benchmark Summary                      โ”ƒ           โ”ƒ
   โ”กโ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ•‡โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”โ”ฉ
   โ”‚ Total Time (HEAD)                      โ”‚ 7649.50ms โ”‚
   โ”‚ Total Time (concat_batches_for_sort)   โ”‚ 7847.31ms โ”‚
   โ”‚ Average Time (HEAD)                    โ”‚  695.41ms โ”‚
   โ”‚ Average Time (concat_batches_for_sort) โ”‚  713.39ms โ”‚
   โ”‚ Queries Faster                         โ”‚         3 โ”‚
   โ”‚ Queries Slower                         โ”‚         1 โ”‚
   โ”‚ Queries with No Change                 โ”‚         7 โ”‚
   โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”ดโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜
   ```
   
   
   </p>
   </details>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to