adriangb commented on PR #15769: URL: https://github.com/apache/datafusion/pull/15769#issuecomment-2848665962
> @adriangb do you have time to address the last suggestions? I understand the mistake here, and I think we should take this in asap I am going to try to address the last round of review later today on a flight. In particular: - https://github.com/apache/datafusion/pull/15769#discussion_r2070806936: change the relevant tests to show the physical plan - https://github.com/apache/datafusion/pull/15769#discussion_r2070258342: try to show _a_ predicate in explain plans (it will not exactly match the final predicate though since the latter will be generated based on the physical file schema) Is there anything I'm missing? Is this what you meant by `the mistake`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
