adriangb commented on code in PR #15769: URL: https://github.com/apache/datafusion/pull/15769#discussion_r2072445465
########## datafusion/sqllogictest/test_files/push_down_filter.slt: ########## @@ -218,43 +219,57 @@ LOCATION 'test_files/scratch/push_down_filter/t.parquet'; query TT explain select a from t where a = '100'; ---- -logical_plan TableScan: t projection=[a], full_filters=[t.a = Int32(100)] +logical_plan +01)Filter: t.a = Int32(100) +02)--TableScan: t projection=[a], partial_filters=[t.a = Int32(100)] # The predicate should not have a column cast when the value is a valid i32 query TT explain select a from t where a != '100'; ---- -logical_plan TableScan: t projection=[a], full_filters=[t.a != Int32(100)] +logical_plan +01)Filter: t.a != Int32(100) +02)--TableScan: t projection=[a], partial_filters=[t.a != Int32(100)] Review Comment: @alamb do you know why these don't display the phyiscal plan already? Is something parsing them out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
