berkaysynnada commented on code in PR #15769:
URL: https://github.com/apache/datafusion/pull/15769#discussion_r2075160616
##########
datafusion/physical-optimizer/src/optimizer.rs:
##########
@@ -95,6 +95,10 @@ impl PhysicalOptimizer {
// as that rule may inject other operations in between the
different AggregateExecs.
// Applying the rule early means only directly-connected
AggregateExecs must be examined.
Arc::new(LimitedDistinctAggregation::new()),
+ // The FilterPushdown rule tries to push down filters as far as it
can.
+ // For example, it will push down filtering from a `FilterExec` to
+ // a `DataSourceExec`, or from a `TopK`'s current state to a
`DataSourceExec`.
+ Arc::new(FilterPushdown::new()),
Review Comment:
If this version is okay in this PR, I can take a look at that in #15770.
I've some ideas, like making FilterPushdown smarter to remove any unnecessary
patterns behind
##########
datafusion/physical-plan/src/filter_pushdown.rs:
##########
@@ -98,6 +116,13 @@ impl PredicateSupports {
.collect()
}
+ /// Are all filters marked as [`PredicateSupport::Supported`]?
+ pub fn is_exact(&self) -> bool {
Review Comment:
can we find a better name for this? and it's not used, maybe removed until
it's needed?
##########
datafusion/core/tests/sql/path_partition.rs:
##########
@@ -57,55 +53,6 @@ use object_store::{
use object_store::{Attributes, MultipartUpload, PutMultipartOpts, PutPayload};
use url::Url;
-#[tokio::test]
-async fn parquet_partition_pruning_filter() -> Result<()> {
Review Comment:
can we also apply the changes similar to the test in
`datafusion/core/tests/parquet/file_statistics.rs ` to keep this test for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
