Chen-Yuan-Lai commented on code in PR #15946: URL: https://github.com/apache/datafusion/pull/15946#discussion_r2077245042
########## datafusion/common/src/error.rs: ########## @@ -808,12 +808,18 @@ make_error!(plan_err, plan_datafusion_err, Plan); // Exposes a macro to create `DataFusionError::Internal` with optional backtrace make_error!(internal_err, internal_datafusion_err, Internal); +// Exposes a macro to create `DataFusionError::IoError` with optional backtrace +make_error!(external_err, external_datafusion_err, External); Review Comment: Hi @comphead, I noticed that using `make_error!` isn't suitable for these error variants because `External` and `ExecutionJoin` are designed to wrap original error objects, not just error messages. Instead, I've implemented custom macros for `External` and `ExecutionJoin` errors, similar to #15796, and replaced a few use cases as examples. Should we replace all the cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
