alamb commented on PR #15946: URL: https://github.com/apache/datafusion/pull/15946#issuecomment-2887542551
I am a little worried about changing the DataFusionError variant as it which will be a disruptive downstream change (users have to update all match statements that currently match on `DataFusionError` and they won't really see any new functionality Rather than change the `DataFusionError` variant, maybe we could model adding a backtrace using `DataFusionError::Context` So keep `DataFusionError::External` and potentially add a backtrace like ``` DataFusionError::External(..) .context(add_backtrace()) ``` Or something like that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org