iffyio commented on PR #1809: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1809#issuecomment-2869271634
> are you closing the PR because you're opposed to supporting batch delimiters at all in this library, or is it that you don't want to accept this particular approach @aharpervc ah to clarify I'm not opposed to supporting the feature itself - my thinking is mainly that the feature is out of scope for the parser since it is not a sql construct, so that supporting it would be at best a nice to have, then had it been easy to include that support we could do so. But afaict so far in this PR, that unfortunately doesn't seem to be the case because there's been a few special case code being introduced to the parser. Basically that the complexity being by the PR from my pov isn't worth the return given that this feature isn't meant to be supported by the parser in the first place. Maybe if the code is much simpler and touches less areas (most importantly I think the core parser loop I highlighted in the previous comment), we could merge such a patch, but I'm unable to say for sure what that looks like, code wise, from my end. But actually I think if we can come up with something that doesn't touch that core parser loop we might have something mergeable. I'll reopen this PR, feel free to iterate if you have ideas to try out and I'm happy to take a look when you do! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
