iffyio commented on PR #1809: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1809#issuecomment-2879231551
> I think it'd be useful read a whole file into a string, then pass it to this library for parsing, then process the AST's Not sure I necessarily agree with this sentiment. I think if there are constructs in a file that arent sql constructs, they should be stripped off from the file before parsing to the library. Parsing non-sql constructs would be out of scope for this library. As a result, similar to ideally avoiding changes to the core parsing loop, I think it would also be undesirable to change or introduce parser APIs in order to support this feature. My current thinking is that if supporting the feature is a low hanging fruit that doesn't introduce too much complexity to the codebase, then we could look to support it as a one-off. Beyond that scenario afaict, downstream users of the library are expected strip off GO lines from input files or do similar preprocessing, before passing input onto the library. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
