berkaysynnada commented on PR #15770: URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2869830929
The PR looks really nice BTW, and every line is clearly understandable. Of course there are some possible optimizations (as you've also noticed some of them like the todo during batch insertion), but this initial version is more than enough IMO. The rule issue is not very trivial because we cannot just track and eliminate some hardcoded patterns, since we also need to be aware of upper parts of the plan, and new patterns may emerge as new tests are added, it's not limited to some specific cases. as I mentioned, I might have found another solution, and if it works I'll ping you and we can merge this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
