adriangb commented on PR #15770: URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2869838330
> The rule issue is not very trivial because we cannot just track and eliminate some hardcoded patterns, since we also need to be aware of upper parts of the plan, and new patterns may emerge as new tests are added, it's not limited to some specific cases. Yes this is unfortunate. Sadly I don’t think that’s even specific to this change: just the way that rules work and are applied iteratively means there’s bound to be conflicts. IMO each rule should have an apply and check step where eg it inserts repartitioning then on the way back up checks if it’s still needed and removes it if not. That way at least the logic is self contained with a rule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
