brayanjuls commented on code in PR #15743:
URL: https://github.com/apache/datafusion/pull/15743#discussion_r2083604044
##########
datafusion/sql/tests/sql_integration.rs:
##########
@@ -4607,82 +4607,58 @@ fn test_prepare_statement_to_plan_params_as_constants()
{
}
#[test]
-fn test_infer_types_from_join() {
+fn test_prepare_statement_infer_types_from_join() {
let sql =
- "SELECT id, order_id FROM person JOIN orders ON id = customer_id and
age = $1";
+ "PREPARE my_plan AS SELECT id, order_id FROM person JOIN orders ON id
= customer_id and age = $1";
let plan = logical_plan(sql).unwrap();
assert_snapshot!(
plan,
@r#"
- Projection: person.id, orders.order_id
- Inner Join: Filter: person.id = orders.customer_id AND person.age = $1
- TableScan: person
- TableScan: orders
+ Prepare: "my_plan" []
+ Projection: person.id, orders.order_id
+ Inner Join: Filter: person.id = orders.customer_id AND person.age = $1
+ TableScan: person
+ TableScan: orders
"#
);
let actual_types = plan.get_parameter_types().unwrap();
let expected_types = HashMap::from([("$1".to_string(),
Some(DataType::Int32))]);
assert_eq!(actual_types, expected_types);
-
- // replace params with values
- let param_values = vec![ScalarValue::Int32(Some(10))];
- let plan_with_params = plan.with_param_values(param_values).unwrap();
-
- assert_snapshot!(
- plan_with_params,
- @r"
- Projection: person.id, orders.order_id
- Inner Join: Filter: person.id = orders.customer_id AND person.age =
Int32(10)
- TableScan: person
- TableScan: orders
- "
- );
Review Comment:
I removed them because without the inferred type changes the tests will fail
because of the validation linked below, which happen after we call
`plan.with_param_values(param_values).unwrap();` in the tests, thats one of the
reason I needed to introduce the inferred type changes.
https://github.com/apache/datafusion/blob/967384e16257bab4deb48bbeff38507ea13c4abd/datafusion/common/src/param_value.rs#L33-L44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
