andygrove commented on code in PR #1744:
URL: https://github.com/apache/datafusion-comet/pull/1744#discussion_r2093551804
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2758,16 +2758,14 @@ object QueryPlanSerde extends Logging with
CometExprShim {
withInfo(join, "SortMergeJoin is not enabled")
None
- case op
- if isCometSink(op) && op.output.forall(a =>
- supportedDataType(
- a.dataType,
- // Complex type supported if
- // - Native datafusion reader enabled (experimental) OR
- // - conversion from Parquet/JSON enabled
- allowComplex =
- usingDataSourceExec(conf) ||
CometConf.COMET_CONVERT_FROM_PARQUET_ENABLED
- .get(conf) ||
CometConf.COMET_CONVERT_FROM_JSON_ENABLED.get(conf))) =>
Review Comment:
These checks were limiting our support for complex types and removing them
exposed a new bug with grouping on maps, which is now fixed in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
